Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(breakoutRooms): migrate service to typescript #11894

Merged
merged 3 commits into from
Mar 28, 2024
Merged

refactor(breakoutRooms): migrate service to typescript #11894

merged 3 commits into from
Mar 28, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 22, 2024 •
edited
Loading

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 22, 2024
@Antreesy Antreesy self-assigned this Mar 22, 2024
@Antreesy Antreesy force-pushed the refactor/noid/migrate-breakout-store branch 2 times, most recently from fabb220 to 0b7330a Compare March 25, 2024 11:24
Base automatically changed from refactor/noid/migrate-breakout-store to main March 25, 2024 11:39
@Antreesy Antreesy force-pushed the refactor/noid/breakout-to-typescript branch from 5495e2b to cd8949c Compare March 28, 2024 08:20
DorraJaouad
DorraJaouad approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types checked and they are correct ✅

src/stores/breakoutRooms.ts Show resolved Hide resolved
@Antreesy Antreesy marked this pull request as ready for review March 28, 2024 14:15
@Antreesy Antreesy merged commit 5f8eeac into main Mar 28, 2024
48 checks passed
@Antreesy Antreesy deleted the refactor/noid/breakout-to-typescript branch March 28, 2024 14:18
@DorraJaouad
Copy link
Contributor

/backport to stable29

@backportbot backportbot bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
2. developing feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @DorraJaouad @nickvergessen